🐛 fix: prevent remark-stringify from unnecessarily escaping underscores - #138
Open
Innei wants to merge 1 commit into
Open
🐛 fix: prevent remark-stringify from unnecessarily escaping underscores#138Innei wants to merge 1 commit into
Innei wants to merge 1 commit into
Conversation
Since emphasis uses '*' and strong uses '*', underscore '_' is never used as a markdown syntax marker. Revert remark-stringify's unnecessary escaping of underscores in text nodes to preserve literal underscores. Fixes lobehub/lobehub#12303
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
👍 @Innei |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatMarkdown()output to revert\_back to_*and strong uses*, underscore_is never a markdown syntax marker in the output_to\_in text nodes unnecessarily, which breaks literal underscores in user inputTest plan
A_i = kin the editor and export markdown — should remainA_i = k(notA\_i = k)*should still work correctlyFixes lobehub/lobehub#12303