Improve invite rejection #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want the client who is rejected to know that (test currently fails)
This doesn't make any sense to me, but Herb suggested it in slack https://devresults.slack.com/archives/CF4NGQM51/p1715721160589369 (and it fixes the broken test I just added)
HerbCaudill
force-pushed
the
invite-rejection
branch
from
8347865 to
f025cab
Compare
|
lgtm I haven't seen any flakiness with the tests - if you still are, could you open an issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When someone attempts to connect to a share using an invite, we want them to be told if the invite is good or bad. This PR adds a test with the desired behavior and then fixes that test with the fix Herb suggested in slack.
Tests get a little flaky with this fix, so there's probably something else we'll need to do