Skip to content

🔧 fix: reassign IN_CONTEXT_EDITOR to plugin id 8 - #14

Merged
elisiondan merged 1 commit into
mainfrom
LOC-4152-in-context-editor-plugin-id-8
Jul 14, 2026
Merged

elisiondan merged 1 commit into
mainfrom
LOC-4152-in-context-editor-plugin-id-8

Conversation

@elisiondan

Copy link
Copy Markdown
Member

What

Reassign IN_CONTEXT_EDITOR from plugin id 7 to 8 in the Services enum.

Why

Plugin id 7 was already taken by INTEGRATION_BRIDGE in the generic-connector server (plugin-connector). That server's get-client-data.ts also had no client-credentials case for 7, so the In-Context Editor OAuth completion (/oauth/complete/7) threw Client id was not found and rendered the connector's generic "Something went wrong" page — the plugin could never finish login on a non-localhost host.

8 is the next free id. Consumers reference the enum member (Services.IN_CONTEXT_EDITOR), not the literal, so this is the only change required here.

Related

  • plugin-connector: adds id 8 (enum + service name + client credentials) — companion PR.
  • server-backend: register the OAuth app with redirectUrl …/oauth/complete/8 — tracked separately.

🤖 Generated with Claude Code

@elisiondan
elisiondan force-pushed the LOC-4152-in-context-editor-plugin-id-8 branch from 6255431 to ce0e880 Compare July 14, 2026 08:45
@elisiondan
elisiondan changed the base branch from main to chore-migrate-pnpm-node22-release-flow July 14, 2026 08:45
@elisiondan

Copy link
Copy Markdown
Member Author

📌 Rebased onto #15 and retargeted to chore-migrate-pnpm-node22-release-flow. This is now a stacked follow-up: merge #15 first, then this PR auto-retargets to main and merges as a clean one-line change (IN_CONTEXT_EDITOR = 7 → 8 in the post-migration unquoted style).

@elisiondan
elisiondan force-pushed the chore-migrate-pnpm-node22-release-flow branch from e5273ec to c14ac7c Compare July 14, 2026 08:49
@elisiondan
elisiondan force-pushed the LOC-4152-in-context-editor-plugin-id-8 branch from ce0e880 to f1302e4 Compare July 14, 2026 08:49
Plugin id 7 collided with INTEGRATION_BRIDGE in the generic-connector server (plugin-connector), whose OAuth completion had no client-credentials case for 7 — so In-Context Editor login failed with "Client id was not found". Move IN_CONTEXT_EDITOR to the next free id, 8. Consumers reference the enum member, not the literal, so this is the only change needed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@elisiondan
elisiondan force-pushed the LOC-4152-in-context-editor-plugin-id-8 branch from f1302e4 to cbb9624 Compare July 14, 2026 09:08
@elisiondan
elisiondan changed the base branch from chore-migrate-pnpm-node22-release-flow to main July 14, 2026 09:08
@elisiondan
elisiondan merged commit baf6e1c into main Jul 14, 2026
@elisiondan
elisiondan deleted the LOC-4152-in-context-editor-plugin-id-8 branch July 14, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants