Fix tests and run tests on ci

[carole-lavillonniere]

1. Fixed the failing unit tests and type check:

--- FAIL: TestResponseTooLarge (0.01s)
    invocationresponse_test.go:67:
        	Error Trace:	/home/carolavillo/Workspaces/localstack/lambda-runtime-init/lambda/rapi/handler/invocationresponse_test.go:67
        	Error:      	Not equal:
        	            	expected: "Response payload size (6291557 bytes) exceeded maximum allowed payload size (6291556 bytes)."
        	            	actual  : "Response payload size exceeded maximum allowed payload size (6291556 bytes)."
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-Response payload size (6291557 bytes) exceeded maximum allowed payload size (6291556 bytes).
        	            	+Response payload size exceeded maximum allowed payload size (6291556 bytes).
        	Test:       	TestResponseTooLarge

lambda/core/directinvoke/customerheaders.go:1: : # go.amzn.com/lambda/core/directinvoke [go.amzn.com/lambda/core/directinvoke.test]
lambda/core/directinvoke/directinvoke_test.go:122:26: cannot use interop.MaxPayloadSize (variable of type int) as int64 value in assignment
lambda/core/directinvoke/directinvoke_test.go:141:26: cannot use interop.MaxPayloadSize (variable of type int) as int64 value in assignment
lambda/core/directinvoke/directinvoke_test.go:166:26: cannot use interop.MaxPayloadSize (variable of type int) as int64 value in assignment
lambda/core/directinvoke/directinvoke_test.go:186:26: cannot use interop.MaxPayloadSize (variable of type int) as int64 value in assignment
lambda/core/directinvoke/directinvoke_test.go:278:26: cannot use interop.MaxPayloadSize (variable of type int) as int64 value in assignment
lambda/core/directinvoke/directinvoke_test.go:313:26: cannot use interop.MaxPayloadSize (variable of type int) as int64 value in assignment (typecheck)

2. Added Github job to run unit tests

[gregfurman]

Why not rather add (or perhaps even replace) the localstack branch inside the Run Integration Tests job?

lambda-runtime-init/.github/workflows/integ-tests.yml

Lines 3 to 6 in 5b81e4c

	on:
	pull_request:
	branches:
	- develop

Seems there is a job there that will ensure the Go tests are run prior to running the int. tests:

lambda-runtime-init/.github/workflows/integ-tests.yml

Lines 8 to 16 in 5b81e4c

	jobs:
	go-tests:
	runs-on: ubuntu-latest
	environment:
	name: integ-tests
	steps:
	- uses: actions/checkout@v4
	- name: run go tests
	run: make tests-with-docker

[carole-lavillonniere]

Thanks for pointing this out, I had missed this integ-tests.yml file!
What I did is delete it, since:

• most jobs it contains are failing at the moment
• the job I added is about unit tests, whereas this workflow is called integ-tests
• I think it makes sense to always run the unit tests before attempting to build

[gregfurman]

Gotcha. Can we keep the integration tests yaml, and just ensure it's skipped/never runs? I think in future, we should be running integration tests with upstream LocalStack IMO.

For example, we can build the go binary, upload it as a workflow artifact, and trigger some upstream LocalStack workflow that ensures we run the Lambda suite with this binary.

[gregfurman]

LGTM! The CI on this repo needs some tlc, so thanks for taking the first step 🙂

I think we should invest some time in better integrating the RIE's CI with upstream LocalStack, but we can tackle this at some other point.