Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default wysiwyg file #174

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Add default wysiwyg file #174

wants to merge 14 commits into from

Conversation

LucasBgt
Copy link
Contributor

Wysiwyg sass file including all default style.
Could be overwritten if needed depending on the project needs.

Headings mixins are commented for now since they're not implemented by default (yet).

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
locomotive-boilerplate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 0:34am

@LucasBgt LucasBgt requested review from Jerek0 and devenini March 27, 2024 22:11
@LucasBgt LucasBgt marked this pull request as ready for review March 27, 2024 22:12
Copy link
Member

@mcaskill mcaskill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awfully convoluted.

Why are there so many margin declarations, repetitions, and adjustments?

Are there no other elements combinations beyond p, ol, ul, table, and figure?

Isn't .c-wysiwyg > * + * good enough, maybe with h1 + *?

What's with the random sprinkling of paddings and pixels?
The latter (pixels) should at least be informed by the related font size.

It would be nice if ol and ul just used the default browser styles instead of relying on pseudo-elements.

assets/styles/components/_wysiwyg.scss Outdated Show resolved Hide resolved
assets/styles/components/_wysiwyg.scss Outdated Show resolved Hide resolved
assets/styles/components/_wysiwyg.scss Outdated Show resolved Hide resolved
assets/styles/components/_wysiwyg.scss Outdated Show resolved Hide resolved
assets/styles/components/_wysiwyg.scss Outdated Show resolved Hide resolved
assets/styles/components/_wysiwyg.scss Outdated Show resolved Hide resolved
assets/styles/components/_wysiwyg.scss Outdated Show resolved Hide resolved
assets/styles/components/_wysiwyg.scss Outdated Show resolved Hide resolved
assets/styles/components/_wysiwyg.scss Outdated Show resolved Hide resolved
@LucasBgt LucasBgt marked this pull request as draft March 28, 2024 00:23
@LucasBgt
Copy link
Contributor Author

Thanks @mcaskill for the complete review. I realized it was way too soon to set this PR 'Ready for review'.
I corrected the majority of the problems you noticed, and gave this wysiwyg file a more standardized vision.
I still suggest to overwrite list (ol and ul) styles, since we need to do it on every single project.
About the spacing method, I think we could try this generic rule, and overwrite if needed for specific elements.

@LucasBgt LucasBgt marked this pull request as ready for review March 28, 2024 15:19
Comment on lines +10 to +12
& > * + * {
margin-bottom: size-clamp('md');
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
& > * + * {
margin-bottom: size-clamp('md');
}
& > * + * {
margin-top: size-clamp('md');
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants