bugfix: set cluster-ip when mapping host to vCluster service #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
|
Hi @FabianKramm. Kindly review this PR and let me know if any changes are required. |
zerbitx
reviewed
Feb 11, 2025
Comment on lines
+222
to
+231
| Ports: fromService.Spec.Ports, | ||
| }, | ||
| } | ||
|
|
||
| // Check if ClusterIP is not "None" | ||
| if fromService.Spec.ClusterIP != corev1.ClusterIPNone { | ||
| toService.Spec.ClusterIP = fromService.Spec.ClusterIP | ||
| } else { | ||
| toService.Spec.ClusterIP = corev1.ClusterIPNone | ||
| } |
There was a problem hiding this comment.
Thank you for this! I haven't had a moment to see if this is the correct fix for the issue, but since this conditional sets to service to none if from service is none, or the value of from service it should be the same as
Suggested change
| Ports: fromService.Spec.Ports, | |
| }, | |
| } | |
| // Check if ClusterIP is not "None" | |
| if fromService.Spec.ClusterIP != corev1.ClusterIPNone { | |
| toService.Spec.ClusterIP = fromService.Spec.ClusterIP | |
| } else { | |
| toService.Spec.ClusterIP = corev1.ClusterIPNone | |
| } | |
| Ports: fromService.Spec.Ports, | |
| ClusterIP: fromService.Spec.ClusterIP, | |
| }, | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #1926. This pull request ensures that the Service cluster-ip is correctly set when mapping the host cluster service to the vCluster service.
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vCluster service mapping resulted in the Service cluster-ip being set to none.
What else do we need to know?
The service was initially appearing as a headless service due to the cluster-ip being displayed as none in the vCluster. In reality, the cluster-ip of the service in the host cluster was being correctly used in the endpoints created within the vCluster. The endpoints in the virtual cluster were pointing to the host cluster's cluster-ip, and despite the none display in the vCluster service, the traffic was correctly routed when the service in the vCluster was used.