Chore/release packaging - #347
Open
0x-r4bbit wants to merge 2 commits into
Open
Conversation
The core-module alias blocks only surfaced the dev `lgx` / `install` outputs, so `nix build .#amm-module-lgx-portable` (the variant you distribute) didn't resolve. Add the `-portable` aliases for both amm_module and token_module, mirroring the UI package aliases. mkLogosModule already produces the portable variants; these just make them addressable.
The per-module flakes couldn't build standalone, so a release repo couldn't build them as separate modules (its CI runs `nix build .#lgx-portable` per module_path): - modules/amm links amm_ffi, a Cargo workspace member (it path-depends on amm_core / token_core / twap_oracle_core), so it can only be built with the whole workspace as source. - apps/amm depends on the amm_module core module, which only the root flake injected. Wire them up: modules/amm pulls amm_ffi from the repo-root flake (path:../..) via externalLibInputs; apps/amm pulls amm_module from the sibling flake (path:../../modules/amm) with inputs.lez_core.follows so the UI and core share one wallet, and adopts the root flake's Basecamp-safe Logos.Wallet staging (the qmldir directive stripping the standalone postInstall was missing). Both now build `.#lgx-portable` on their own — verified end to end. The repo-root flake is unaffected: it builds src = ./modules/amm / ./apps/amm with its own inputs and ignores these subdir flakes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.