Conversation
The current chat_module emits chatCreateIntroBundleResult as a single JSON string; ChatBackend still read the legacy [bool,int,str] array → always 'Failed to create intro bundle'. Parse JSON, fall back to the array format. (Separate from the QR card.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ChatBackend::onChatCreateIntroBundleResultreads the bundle event as a legacy[bool, int, string, …]array (data[0].toBool(),data[2].toString()). But the currentchat_module(logos-chat-module, latest) emits the event as a single JSON string:So
successparses asfalseand every "Get Intro Bundle" fails with "Failed to createintro bundle" — even though the module created the bundle successfully (verified: chat_module
logs
IntroBundleCreated, ret 0).Fix
Parse
data[0]as JSON ({"success", "introBundle"}), falling back to the legacy arrayformat for older
chat_modulebuilds. One-file change inChatBackend.cpp.Independent of any feature — this unblocks the intro-bundle flow against the current chat_module.