feat: gate the plugin's own diagnostics behind a log level - #65
Draft
osmaczko wants to merge 1 commit into
Draft
Conversation
📊 delivery-module doc-test reportThis commit of the delivery module, packaged as an Pages can take a minute to update after the run finishes. |
Every diagnostic the plugin printed went to stderr unconditionally, and two of them fire on every delivery event the node emits, so an embedding host took a per-event line plus a dump of the full event payload, message contents included, into its console and its log files. Verbosity now follows createNode's `logLevel`, shared with the node's own logger, with `DELIVERY_MODULE_LOG_LEVEL` overriding it for the plugin's own lines and covering the ones printed before a configuration arrives. Each line carries the token the host's stderr classifier keys on, so a forwarded line is logged at its real severity rather than always at info.
osmaczko
force-pushed
the
feat/leveled-plugin-logging
branch
from
July 21, 2026 13:08
bd8f2f8 to
978b775
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every diagnostic the plugin printed went to stderr unconditionally, and two of them fire on every delivery event the node emits, so an embedding host took a per-event line plus a dump of the full event payload, message contents included, into its console and its log files.
Verbosity now follows createNode's
logLevel, shared with the node's own logger, withDELIVERY_MODULE_LOG_LEVELoverriding it for the plugin's own lines and covering the ones printed before a configuration arrives. Each line carries the token the host's stderr classifier keys on, so a forwarded line is logged at its real severity rather than always at info.Scope: the module's own diagnostics. The embedded node logs separately, to stdout, and this change does not affect it, so it does not on its own quiet the console output reported in logos-co/logos-chat-ui#37 — the lines there are the node's. Making the node honor
logLevelis a fix in logos-delivery's nix build, tracked separately.