Skip to content

fix: repin nixpkgs with fetchCargoVendor User-Agent hotfix (crates.io 403 breaking all module releases) #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danisharora099 wants to merge 1 commit into from
Closed

fix: repin nixpkgs with fetchCargoVendor User-Agent hotfix (crates.io 403 breaking all module releases) #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions flake.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,15 @@
logos-rust-sdk.inputs.logos-nix.follows = "logos-nix";
logos-rust-sdk.inputs.logos-module-builder.follows = "logos-cpp-sdk";
logos-rust-sdk.inputs.logos-logoscore-cli.follows = "logos-cpp-sdk";
nixpkgs.follows = "logos-nix/nixpkgs";
# HOTFIX (#159): crates.io now rejects the UA-less python fetch in this
# pin's fetchCargoVendor with HTTP 403, which breaks cargo vendoring in
# every module release that follows this flake's nixpkgs. This pin is the
# exact rev logos-nix locks (e9f00bd8) plus ONE commit: the upstream
# User-Agent fix (adapted from NixOS/nixpkgs@8209ba2b, NixOS/nixpkgs#512735),
# so the package set is byte-identical and all fixed-output hashes stay
# valid. Revert to `nixpkgs.follows = "logos-nix/nixpkgs"` once logos-nix
# advances past 2026-04-26 (first nixos-unstable containing the fix).
nixpkgs.url = "github:danisharora099/nixpkgs/eaec81d3b8a8d2339e25c718a1650b2c45adf726";

@Khushboo-dev-cpp Khushboo-dev-cpp Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the infra team needs to look at this ? and the fix should land in logos-nix repo ? @dlipicar , who do we ping ?

@danisharora099 danisharora099 Aug 11, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra team perhaps? cc @jakubgs

@dlipicar dlipicar Aug 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I'm guessing the fix should go in logos-nix.
@danisharora099 could you raise the PR with whatever you changed in your fork there? then we re-pin this one

@jakubgs jakubgs Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 lines of useless LLM slop comment, that must be a new record. You do know it does this so you pay more for input tokens when re-parsing files?

As for nixpkgs commit picked here, why do you need to use your fork of nixpkgs from @danisharora099 c?
Second of all, the fetchCargoVendor fix was applied in NixOS/nixpkgs#512735 so why can't you just update nixpkgs in logos-nix to one that includes that? Windows nixpkgs uses b5aa0fbd538984f6e3d201be0005b4463d8b09f8 commit which already includes the rustPlatform.fetchCargoVendor: set custom User-Agent in v2 fix, so why not just unify it?

@jakubgs jakubgs Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what in the hell is this flake.lock...

~/work/logos-module-builder master
 > wc -l flake.lock                       
76166 flake.lock

~/work/logos-module-builder master
 > jq '.nodes | keys' flake.lock | grep nixpkgs | wc -l
1016

@danisharora099 danisharora099 Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 lines of useless LLM slop comment, that must be a new record. You do know it does this so you pay more for input tokens when re-parsing files?

XD flip side is it saves working out what that line is doing from scratch every time - cheaper to read it than to rediscover it. Happy to trim it though.

As for nixpkgs commit picked here, why do you need to use your fork of nixpkgs from @danisharora099 c?
Second of all, the fetchCargoVendor fix was applied in NixOS/nixpkgs#512735 so why can't you just update nixpkgs in logos-nix to one that includes that? Windows nixpkgs uses b5aa0fbd538984f6e3d201be0005b4463d8b09f8 commit which already includes the rustPlatform.fetchCargoVendor: set custom User-Agent in v2 fix, so why not just unify it?

Fair points. WIP

@jakubgs jakubgs Aug 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it saves working out what that line is doing from scratch every time

A comment should be one line, two lines if there's a link to a related issue or PR. Anything beyond that is noise.

And besides, actual reason for a change is in Git history. Just use git blame.

};

outputs = { self, nixpkgs, logos-cpp-sdk, logos-protocol, logos-qt-sdk, logos-module, logos-plugin-qt, logos-plugin-core, nix-bundle-logos-module-install, nix-bundle-lgx, logos-standalone-app, logos-test-framework, logos-rust-sdk, rust-overlay ? null, ... }:
Expand Down
Loading