NomosDA update v1 verifier #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielSanchezQ
approved these changes
Jan 29, 2025
danielSanchezQ
added a commit
that referenced
this pull request
Jan 29, 2025
* Modify and rename hash_commitment method. Now we just hash the column commitment itself. * Fix calls * Remove certificate from verifier * Update verifier * Fix tests * Fix verifier imports * Fix more imports * Fix dispersal * Fix more imports * Fix missing parameter in dispersal * Fix tests * Full flow renaming * Disperse encoded data in full flow test * Make da verification indempotent (#118) --------- Co-authored-by: Gusto <[email protected]> Co-authored-by: gusto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets
update-v1PR, removes mentions about attestations, simplifies the verifier function with a comment about the implementer responsibility to make verification idempotent.