feat(da/replication): cache replication messages regardless of source #1136
+21
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHr15F0x
force-pushed
the
cl/always-cache
branch
from
b6c2252 to
6dc095f
Compare
CHr15F0x
force-pushed
the
cl/always-cache
branch
from
6dc095f to
5b3a57f
Compare
bacv
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. What does this PR implement?
Previously, replication messages were not cached if their sending was initiated from dispersal. This caused excessive replication traffic. This PR changes this behaviour - a replication message is always cached on its first occurrence.
2. Does the code have enough context to be clearly understood?
Yes.
3. Who are the specification authors and who is accountable for this PR?
Spec: @danielSanchezQ
PR: @CHr15F0x
4. Is the specification accurate and complete?
Yes.
5. Does the implementation introduce changes in the specification?
No.
Checklist
Warning
Do not merge the PR if any of the following is missing: