fix(DA): Sampling behaviour lost requests #1143
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. What does this PR implement?
It was observed that even in the perfect network conditions some sampling requests wouldn't be sent. There were couple of cases that were not handled as sampling behavior doesn't necessary start the stream between peers:
open_stream
returnsConnectionReset
io error, sample request fails.Since dispersal service now has an option to try sampling before publishing into the mempool, a small change was made in sampling service to ensure that sampling service invalidates only blobs that it was requested to sample.
One other change might not be very obvious, but receiving end now tries to listen to the incoming stream as long as it gets the close Eof signal from remote peer. Outgoing and Incoming tasks are put into the same tasks queue.
2. Does the code have enough context to be clearly understood?
3. Who are the specification authors and who is accountable for this PR?
4. Is the specification accurate and complete?
5. Does the implementation introduce changes in the specification?
Checklist