Alias watchdog type column as "watchdog_type" #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids clash with Elasticsearch type field.
PHP/Drupal writes them as UTF-8, but the charset being used by the MySQL JDBC Java ResultSet was ISO-8859-1. The field is a blob in the database, so encodings don't make much sense. This forced conversion makes all the encodings line up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids clash with Elasticsearch type field.
I have signed the CLA. However I did add the email address of the commit author to this account after signing. Could someone at Elasticsearch let me know why the check still fails?
The build seems to have been failing for some time for different reasons.