allow custom framework use args in refactor templates #1290
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now custom framework cannot use args in refactor templates.
with refactor template
i18n.t('$1')
ini18n-ally-custom-framework.yml
,when we extract text like
`hello, ${'world'}`
,we will only get
i18n.t("<keypath of 'hello, {0}'>")
,but we need
i18n.t("<keypath of 'hello, {0}'>", ['world'])
,here is no way to do this now.
but with this patch, and config below, it will works as we need
notice: the first template with
$2
only used with args not empty, so we need a template without$2
for fallback