feat: allow empty array in createAll method #2410
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samarpanB
requested changes
Jun 5, 2025
| @@ -512,11 +512,18 @@ DataAccessObject.createAll = function(dataArray, options, cb) { | |||
| options = options || {}; | |||
| cb = cb || utils.createPromiseCallback(); | |||
|
|
|||
| assert(typeof dataArray === 'object' && dataArray.length, | |||
| 'The data argument must be an array with length > 0'); | |||
| assert(typeof dataArray === 'object' && Array.isArray(dataArray), | |||
There was a problem hiding this comment.
Can we make it configurable in order to ensure backward compatibility ?
|
Also please sign off your commit. Follow DCO here - https://loopback.io/doc/en/contrib/code-contrib.html |
Signed-off-by: Ajay Prajapati <[email protected]>
ajay-prajapati07
force-pushed
the
GH-2409
branch
from
723ab31 to
f6eee84
Compare
Pull Request Test Coverage Report for Build 15629436334Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Can you please add a test case for this option ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to allow empty array in createAll method. Currently it throws error.
Include references to all related GitHub issues and other pull requests, for example:
Fixes #2409
-->
Checklist
npm testpasses on your machine