Merge pull request #37 from fawno/psalm-fix-tin

Fix parse method on TIN class: https://psalm.dev/078

LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2020-2023 Thomas Portelange, Pol Dellaiera
+Copyright (c) 2020-2024 Thomas Portelange, Pol Dellaiera
 
 Permission is hereby granted, free of charge, to any person obtaining a copy of
 this software and associated documentation files (the "Software"), to deal in

composer.json

@@ -42,10 +42,10 @@
     },
     "config": {
         "allow-plugins": {
+            "ergebnis/composer-normalize": true,
             "infection/extension-installer": true,
-            "phpstan/extension-installer": true,
             "phpro/grumphp": true,
-            "ergebnis/composer-normalize": true
+            "phpstan/extension-installer": true
         }
     },
     "scripts": {

src/Exception/TINException.php

@@ -16,6 +16,11 @@
  */
 final class TINException extends Exception
 {
+    public static function emptySlug(): TINException
+    {
+        return new self('Invalid Slug. Reason: Void string.');
+    }
+
     public static function invalidCountry(string $countryCode): TINException
     {
         return new self(sprintf('No handler available for this country code: %s.', $countryCode));

src/TIN.php

@@ -141,13 +141,19 @@ private function getAlgorithm(string $country, ?string $tin = null): CountryHand
     /**
      * @throws TINException
      *
-     * @return array<string, string>
+     * @return non-empty-array<'country'|'tin', string>
      */
     private function parse(string $slug): array
     {
-        return array_combine(
-            ['country', 'tin'],
-            sscanf($slug, '%2s%s')
-        );
+        if ('' === $slug) {
+            throw TINException::emptySlug();
+        }
+
+        [$country, $tin] = sscanf($slug, '%2s%s') + ['', ''];
+
+        return [
+            'country' => (string) $country,
+            'tin' => (string) $tin,
+        ];
     }
 }