Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Spain country handler to support Natural Persons without DNI or NIE and Non-Natural Persons TIN formats #41

Merged
merged 13 commits into from
Jun 6, 2024

Conversation

alphp
Copy link
Contributor

@alphp alphp commented Jun 6, 2024

Rebased changes of #36

@alphp alphp requested a review from lekoala as a code owner June 6, 2024 21:54
Copy link

what-the-diff bot commented Jun 6, 2024

PR Summary

  • New File for Spain's Tax Identification Numbers
    A new document has been added, providing information about tax identification numbers (TIN) in Spain. This can serve a useful reference for understanding tax-related rules and regulations in Spain.

  • Updating Spain's Tax Identification Algorithm
    The code files relating to Spain's TIN validation and implementation have been updated:

    • Constants related to the validation of TINs have been updated in the SpainSpec.php file.
    • A method has been updated in the CountryHandler.php file to ignore case sensitivity during pattern matching, effectively enhancing the system's robustness in handling user inputs.
    • In the Spain.php file, several methods have been revamped. The changes include updates to the values of the NIE constant, incorporation of the checksum handling into various methods for improved functional accuracy and updates in validation rules.

These changes provide a more accurate validation process for Spain's TINs, improving the robustness and reliability of the system overall.

@drupol
Copy link
Contributor

drupol commented Jun 6, 2024

Sad you opened a new PR :( but OK I'll give my final thoughts tomorrow.

@alphp
Copy link
Contributor Author

alphp commented Jun 6, 2024

I can't express my anger at having to do it like this after so much work.
But this week has been very complicated both personally and professionally: I can't take it anymore.

@drupol
Copy link
Contributor

drupol commented Jun 6, 2024

I can take care of it if you want, so we don't loose the history? Are you OK if I do it myself?

@alphp
Copy link
Contributor Author

alphp commented Jun 6, 2024

That would be great.
Thank you so much for all your patience with me.

@drupol
Copy link
Contributor

drupol commented Jun 6, 2024

That would be great. Thank you so much for all your patience with me.

No problem, can you check if I have the right to push to your repo? add me as collaborator and I'll fix the mess.

ERROR: Permission to fawno/tin.git denied to drupol.

@drupol drupol force-pushed the refactor-spain-country-handler branch from 13833d7 to 3bfd34b Compare June 6, 2024 22:19
@drupol drupol merged commit 3bfd34b into loophp:master Jun 6, 2024
14 checks passed
@drupol drupol mentioned this pull request Jun 6, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants