Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict mode: Fix readme.md and fix getTIN function #43

Closed
wants to merge 5 commits into from
Closed

Strict mode: Fix readme.md and fix getTIN function #43

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e2ca568
Update README.md
ortegafernando Jun 8, 2024
5613450
Fix strick mode in getTIN function
ortegafernando Jun 8, 2024
a3c0e25
Added hasAlgorithm public function
ortegafernando Jun 8, 2024
aaeaa0c
Update TIN.php
ortegafernando Jun 8, 2024
d8ec747
Merge branch 'master' into master
drupol Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ TIN::fromSlug('be7110.2512345')->check(); // Not strict
TIN::fromSlug('be7110.2512345')->check(strict: false); // Not strict
TIN::fromSlug('be7110.2512345')->check(true); // Strict
TIN::fromSlug('be7110.2512345')->check(strict: true); // Strict

```

## Installation

Expand Down
6 changes: 1 addition & 5 deletions src/CountryHandler/CountryHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,7 @@ final public function __construct(string $tin = '')

public function getTIN(): string
{
if (null !== $string = preg_replace('#[^[:alnum:]\-+]#u', '', $this->tin)) {
return strtoupper($string);
}

return '';
return strtoupper($this->tin);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to keep that in the existing normalize function. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree you

}

final public static function supports(string $country): bool
Expand Down
11 changes: 11 additions & 0 deletions src/TIN.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,17 @@ public function isValid(bool $strict = false): bool
return true;
}

public function hasAlgorithm(): bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about keeping the "algorithm" side of things internally and expose a simpler interface?

In this case, I would just name this method isSupported() ? WDYT ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is better, I agree you, better isSupported()

{
$parsedTin = $this->parse($this->slug, false);
foreach ($this->algorithms as $algorithm) {
if (true === $algorithm::supports($parsedTin['country'])) {
return true;
}
}
return false;
}

/**
* @throws TINException
*/
Expand Down
Loading