Container control buttons #649
Conversation
Added start and stop service buttons for each service in a stack by changes to the container and compose components as well as the socket handler and the stack class.
added restart service/container button as well as fixed start/stop buttons for correct statuses of healthy/unhealthy
|
I didn't have any of the errors coming up in the checks when i built it or when i ran the built docker container on my end. Most all of those errors appear to be code I did not modify so I'm not sure if that is relevant to these modifications. |
swapped to double quotes from singles on service functions
|
Waiting for this! |
|
@louislam why we don't merge this pr? |
|
@louislam please merge this, this feature is the only feature I think is missing from dockge |
|
Waiting for this to be in the Image. |
|
Could this please be merged? This is a very much required feature that will really make dockge stand out. |
|
I tried this when merged on my fork, and seem to have no effect on the containers ... |
|
@Triskae not sure if anything changed as there has been some version changes to a lot of packages and I have not updated and tested my dockge docker build as I spent far longer than i'd like to admit getting it to build on my test system at the time. I did put a docker image up on docker hub thejericko/dockge:latest but like I said it's not the latest dockge version since the update was released right after I built that. |
I understand, I will take a look if can make it work ! Or if you want, you can take a look too.
Ooooh yeah me too .... on macos with M2 Chip impossible for me to getting it to build, had to create a linux VM .... |
Add missing endpoints for PR louislam#649
…ntainer control buttons
…ntainer control buttons
|
FYI, when testing this I noticed that I'm getting quite a few JS warnings in my browser. |
| stack.joinCombinedTerminal(socket); // Ensure the combined terminal is joined | ||
| callbackResult({ | ||
| ok: true, | ||
| msg: "Service" + serviceName + " started" |
There was a problem hiding this comment.
| msg: "Service" + serviceName + " started" | |
| msg: "Service " + serviceName + " started" |
| await stack.stopService(socket, serviceName); | ||
| callbackResult({ | ||
| ok: true, | ||
| msg: "Service" + serviceName + " stopped" |
There was a problem hiding this comment.
| msg: "Service" + serviceName + " stopped" | |
| msg: "Service " + serviceName + " stopped" |
| await stack.restartService(socket, serviceName); | ||
| callbackResult({ | ||
| ok: true, | ||
| msg: "Service" + serviceName + " restarted" |
There was a problem hiding this comment.
| msg: "Service" + serviceName + " restarted" | |
| msg: "Service " + serviceName + " restarted" |
https://github.com/louislam/dockge/blob/master/CONTRIBUTING.md
Tick the checkbox if you understand [x]:
Description
New Feature - Control of individual containers for starting, stopping, and restarting.
Fixes #(issue)
Fixes having to restart or stop and start the entire stack when you just want to do one container
Type of change
Checklist
(including JSDoc for methods)
Screenshots (if any)