Fix workflow input: rename build-mode to build_mode#16
Open
sclaiborne wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames the workflow_dispatch input
build-modetobuild_modeand updates the dot-notation reference accordingly.Why
Hyphenated input names get parsed as subtraction in ${{ inputs. }} expressions —
inputs.build-modeis interpreted asinputs.buildminusmode, which always evaluates to null. Combined with the|| 'Build'fallback, manualworkflow_dispatchruns effectively ignored the user's selection and always built as 'Build'. PR triggers were unaffected.Snake_case lets the dot-notation reference work correctly. The
|| 'Build'fallback continues to handle the missing-inputs context onpull_requesttriggers.Same fix landed across the AS6 sweep so all repos converge on the same template.
Caught by Copilot review on a sibling repo's workflow.