[kmac, rtl/dv/sw] Remove unused error code #25035
Conversation
hw/ip/kmac/rtl/kmac_pkg.sv
Outdated
| // Error Shadow register update | ||
| ErrShadowRegUpdate = 8'h C0, | ||
|
|
||
| // Error due to lc_escalation_en_i or fatal fault | ||
| ErrFatalError = 8'h C1, | ||
| ErrFatalError = 8'h C0, | ||
|
|
||
| // Error due to the counter integrity check failure inside MsgFifo.Packer | ||
| ErrPackerIntegrity = 8'h C2, | ||
| ErrPackerIntegrity = 8'h C1, | ||
|
|
||
| // Error due to the counter integrity check failure inside MsgFifo.Fifo | ||
| ErrMsgFifoIntegrity = 8'h C3 | ||
| ErrMsgFifoIntegrity = 8'h C2 |
There was a problem hiding this comment.
I think the "right" way to handle this would be just remove ErrShadowRegUpdate without modifying the other encodings. Because touching the other encodings would mean an change to the software interface: software compliant with A0/A1 would only be partially compatible. This would mean a version increment. We should avoid this at this point.
Maybe it we should just remove it now but add a note somewhere (in an issue?) to edit also the other encodings next time we do an interface change anyway?
There was a problem hiding this comment.
Done.
My assumption was that SW from the master branch anyways is not compatible with A0/A1 (for different reasons). Hence, I decided to make the change more clean by also moving the error codes.
I created an issue (#25052) for that.
There was a problem hiding this comment.
Thanks Pascal! You're right about this but we still want to be careful about introducing breaking changes into the IPs if possible.
The `ErrShadowRegUpdate` code is never used in the RTL. Instead, according to the documentation, on a shadow register update error, a recoverable alert shall be triggered - this recoverable alert then is signaled in the STATUS register and not in the error code register. Hence, this commit removes this error code as well as the corresponding SW code (`kDifErrorShadowRegisterUpdate`). Signed-off-by: Pascal Nasahl <[email protected]>
nasahlpa
force-pushed
the
kmac_del_err_shadow_reg_update
branch
from
4f7dcf1
to
6fb13be
Compare
|
CHANGE AUTHORIZED: hw/ip/kmac/rtl/kmac_pkg.sv This PR touches an RTL file to remove an unused error code. The used error codes are not touches. This is okay. |
nasahlpa
requested review from
matutem and
jadephilipoom
and removed request for
a team,
andreaskurth,
matutem and
jadephilipoom
|
CHANGE AUTHORIZED: hw/ip/kmac/rtl/kmac_pkg.sv This PR touches an RTL file to remove an unused error code. The used error codes are not touches. This is okay. |
The
ErrShadowRegUpdatecode is never used in the RTL. Instead, according to the documentation, on a shadow register update error, a recoverable alert shall be triggered - this recoverable alert then is signaled in the STATUS register and not in the error code register.Hence, this commit removes this error code as well as the corresponding SW code (
kDifErrorShadowRegisterUpdate).