Skip to content

Conversation

rivos-eblot
Copy link

@rivos-eblot rivos-eblot commented Oct 2, 2025

  • Improve companion tools to support multiple file formats for ROM image (ELF/BIN/VMEM.32/VMEM.39/HEX)
  • Optimizations as pure Python scrambling is noticeably slow, especially with 64KiB ROM file
  • Add QEMU scrambling for non-scrambled file so that KeyManager DPE can generate accurate attestations even when loaded ROM are not scrambled, such as ELF files

@rivos-eblot rivos-eblot changed the title [Draft] Improve ROM image support Improve ROM image support Oct 3, 2025
@rivos-eblot rivos-eblot changed the title Improve ROM image support tools: Improve ROM image support Oct 3, 2025
@rivos-eblot rivos-eblot force-pushed the dev/ebl/rom_img branch 2 times, most recently from f3ed1d6 to b76194c Compare October 3, 2025 16:26
@rivos-eblot rivos-eblot requested a review from AlexJones0 October 3, 2025 16:44
Copy link

@AlexJones0 AlexJones0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after my remaining comments are addressed.

- cache computation results when it makes sense
- avoid computing constants more than once

Signed-off-by: Emmanuel Blot <[email protected]>
- cache some computation results

Signed-off-by: Emmanuel Blot <[email protected]>
…d ECC

This should enable support for loading ELF, binary and plain text VMEM files
as ROM image file while preserving proper KeyManager DPE computations,
which is expected to be performed on scrambled address & ECC ROM content.

Signed-off-by: Emmanuel Blot <[email protected]>
srecord can't help adding a useless comment before the generated VMEM file

Skip what may look like a C comment to better detect text file format.

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot rivos-eblot merged commit 1d37073 into lowRISC:ot-9.2.0 Oct 6, 2025
9 checks passed
@rivos-eblot rivos-eblot deleted the dev/ebl/rom_img branch October 6, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants