-
Notifications
You must be signed in to change notification settings - Fork 11
tools
: Improve ROM image support
#208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tools
: Improve ROM image support
AlexJones0
reviewed
Oct 3, 2025
f3ed1d6
to
b76194c
Compare
b76194c
to
929aa8e
Compare
AlexJones0
approved these changes
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after my remaining comments are addressed.
Signed-off-by: Emmanuel Blot <[email protected]>
…EM files Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
…ble ROM images Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
- cache computation results when it makes sense - avoid computing constants more than once Signed-off-by: Emmanuel Blot <[email protected]>
- cache some computation results Signed-off-by: Emmanuel Blot <[email protected]>
…d ECC This should enable support for loading ELF, binary and plain text VMEM files as ROM image file while preserving proper KeyManager DPE computations, which is expected to be performed on scrambled address & ECC ROM content. Signed-off-by: Emmanuel Blot <[email protected]>
srecord can't help adding a useless comment before the generated VMEM file Skip what may look like a C comment to better detect text file format. Signed-off-by: Emmanuel Blot <[email protected]>
929aa8e
to
c6e73dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.