-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Darjeeling implementation #65
Merged
rivos-eblot
merged 65 commits into
lowRISC:ot-darjeeling-8.2.0
from
rivos-eblot:dev/ebl/update_dj
May 31, 2024
Merged
Update Darjeeling implementation #65
rivos-eblot
merged 65 commits into
lowRISC:ot-darjeeling-8.2.0
from
rivos-eblot:dev/ebl/update_dj
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix an invalid error report type. Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
- explicit timeout message - add close() to ProxyEngine - add quit() wrapper to DeviceProxy Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
- discard casting-through-void, as QEMU heavily relies on ptr casting - discard multi-level-implicit-pointer-conversion, as Glib likes casts - discard macro-to-enum which is not fitted for C language - discard redundant-casting which consider bool and int as strictly eq. - discard avoid-nested-conditional-operator, useful for ?: operator
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
…andler EarlGrey/Darjeeling alert handlers will be replaced by a new shared implementation in a later commit. Disable instantiation of current versions to avoid breaking bisect during the transition. Signed-off-by: Loïc Lefort <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Also move instantiation calls instance_init. Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
This option may be used in a test configuration section, to tell pyot.py what QEMU is expected to fail with a specific error code. Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
…ommon Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Count of arguments exchanged between a couple of methods in pyot.py as grown to a hardly readable list. Replace it with a dictionary which is easier to debug and extend with new features. Signed-off-by: Emmanuel Blot <[email protected]>
debug may be None, overriding the pre-parsed default setting. Signed-off-by: Emmanuel Blot <[email protected]>
- do not use critical log level for expected failure - post context execution should be performed if failure matches expected one Signed-off-by: Emmanuel Blot <[email protected]>
…warning Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Update protocol and implementation to generalize interrupt interception to all qemu_irq of a device, not only the system bus IRQs. Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
It helps differentiating QEMU traces from pyot.py and other tool messages Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
getLevelNamesMapping() has been added in Python 3.11. Add a replacement function for previous Python releases. Signed-off-by: Emmanuel Blot <[email protected]>
When setting CFG0.STEP to 0 and a compare value greater than the current timer value, QEMU would crash with a division by 0. Fix this issue by skipping QEMU internal timer scheduling when STEP=0 (same as a disabled ot_timer). Signed-off-by: Loïc Lefort <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
loiclefort
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (already reviewed and tested at Rivos)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-jtag tcp::3335
is replaced with-chardev socket,id=taprbb,host=localhost,port=3335,server=on,wait=off
pyot.py