Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf improvements #314

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Perf improvements #314

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
c516525
pinmux: changed spi signals to match common names
HU90m Oct 29, 2024
c5d0f42
pinmux: changed pwm signal name
HU90m Oct 30, 2024
96e6d7c
pinmux: explicitly set sizes for combined output selectors
HU90m Oct 31, 2024
bec0c19
pinmux: Added remaining devices to the headers and pmod
HU90m Oct 31, 2024
c2265d4
sonata_system: dedicated spi devices pulled out of pinmux
HU90m Nov 1, 2024
f9f30c6
doc: updated pin mappings diagram to reflect spi changes
HU90m Nov 1, 2024
248a851
pinmux: removed block inputs with no input options.
HU90m Nov 1, 2024
c27d4cd
Pinmapping uart and spi fixup
marnovandermaas Nov 1, 2024
cb76457
top: added the pmodc gpio block and pins
HU90m Nov 1, 2024
e403668
Update SW definitions of number of GPIO/UART/SPI
AlexJones0 Nov 1, 2024
97c6735
Update manual pinmux checker for new pin mapping changes
AlexJones0 Oct 31, 2024
029c903
Update pinmux tests for mapping changes & convert SPI test to use ext…
AlexJones0 Nov 1, 2024
09ba375
Attach Basic PMOD SF3 SPI DPI to PMOD1 in Verilator
AlexJones0 Nov 1, 2024
e523ec8
Add PMODC pins to XDC file
AlexJones0 Nov 1, 2024
a23c6e5
Increase optimisation level
elliotb-lowrisc Oct 31, 2024
dd85088
[rtl] Add register stage to SPI internal loopback
GregAC Nov 3, 2024
c4ff981
[ci] Save bitstream utilization and timing reports as artifacts
GregAC Nov 3, 2024
f0ff867
[rtl] Increase outstanding requests in SRAM wrapper
GregAC Oct 28, 2024
a2b4006
Update lowrisc_ibex to lowrisc/cheriot-ibex@ea2df9db
GregAC Oct 28, 2024
0f366cb
[rtl] Explicitly set RV32B/RV32M for Ibex
GregAC Oct 28, 2024
8235bc7
Switch to single cycle multiplier for Ibex
GregAC Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ jobs:
runs-on: [ubuntu-22.04-fpga, sonata]
env:
BITSTREAM_PATH: build/lowrisc_sonata_system_0/synth-vivado/lowrisc_sonata_system_0.bit
TIMING_RPT: build/lowrisc_sonata_system_0/synth-vivado/lowrisc_sonata_system_0.runs/impl_1/top_sonata_timing_summary_routed.rpt
Copy link
Contributor

@elliotb-lowrisc elliotb-lowrisc Nov 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to make this conditional on whether "top_sonata_timing_summary_postroute_physopted.rpt" exists, so we avoid looking at the wrong report when we switch to the new 2024.1-compatible post-route optimisation flow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think easier to just remember to fix this up when we alter the tool version. It's reasonable for CI to specifically work with the currently agreed tool versions and need modest updates when we change versions.

UTILIZATION_RPT: build/lowrisc_sonata_system_0/synth-vivado/lowrisc_sonata_system_0.runs/impl_1/top_sonata_utilization_placed.rpt
GS_PATH: gs://lowrisc-ci-cache/lowRISC/sonata-system/bitstream

steps:
Expand Down Expand Up @@ -129,6 +131,14 @@ jobs:
module load xilinx/vivado
nix run .#bitstream-build

- name: Upload implementation reports
uses: actions/upload-artifact@v4
with:
name: implementation-reports
path: |
${{ env.TIMING_RPT }}
${{ env.UTILIZATION_RPT }}

# Only upload the bistream if this is not a pull-request and the build bistream step ran.
- name: Upload bitstream to the cache
if: github.event_name != 'pull_request' && env.file_exists == 'false'
Expand Down
8 changes: 8 additions & 0 deletions data/pins_sonata.xdc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,14 @@ set_property -dict { PACKAGE_PIN E17 IOSTANDARD LVCMOS33 IO_BUFFER_TYPE NONE } [
set_property -dict { PACKAGE_PIN D17 IOSTANDARD LVCMOS33 IO_BUFFER_TYPE NONE } [get_ports {pmod0[6]}]
set_property -dict { PACKAGE_PIN K13 IOSTANDARD LVCMOS33 IO_BUFFER_TYPE NONE } [get_ports {pmod0[7]}]

## PMODC (pins between PMOD0 and PMOD1 on shared connector)
set_property -dict { PACKAGE_PIN K15 IOSTANDARD LVCMOS33 IO_BUFFER_TYPE NONE } [get_ports {pmodc[0]}] ;# PMODC_1 on schematic
set_property -dict { PACKAGE_PIN J15 IOSTANDARD LVCMOS33 IO_BUFFER_TYPE NONE } [get_ports {pmodc[1]}] ;# PMODC_2
set_property -dict { PACKAGE_PIN K16 IOSTANDARD LVCMOS33 IO_BUFFER_TYPE NONE } [get_ports {pmodc[2]}] ;# ...
set_property -dict { PACKAGE_PIN J18 IOSTANDARD LVCMOS33 IO_BUFFER_TYPE NONE } [get_ports {pmodc[3]}]
set_property -dict { PACKAGE_PIN F18 IOSTANDARD LVCMOS33 IO_BUFFER_TYPE NONE } [get_ports {pmodc[4]}]
set_property -dict { PACKAGE_PIN J17 IOSTANDARD LVCMOS33 IO_BUFFER_TYPE NONE } [get_ports {pmodc[5]}]

## PMOD1
set_property -dict { PACKAGE_PIN B18 IOSTANDARD LVCMOS33 IO_BUFFER_TYPE NONE } [get_ports {pmod1[0]}]
set_property -dict { PACKAGE_PIN E16 IOSTANDARD LVCMOS33 IO_BUFFER_TYPE NONE } [get_ports {pmod1[1]}]
Expand Down
Loading