Skip to content

Development: Adapt staging deployment to use Ansible #10627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 2, 2025

Conversation

Hialus
Copy link
Member

@Hialus Hialus commented Apr 1, 2025

Checklist

General

Motivation and Context

We want to move the deployment of staging and production to use our Ansible setup.

Description

I've adapted the staging deployment workflow to use our Ansible setup for deployment.

Steps for Testing

Already tested -> See workflow runs

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

@helios-aet helios-aet bot temporarily deployed to artemis-staging-localci.artemis.cit.tum.de April 1, 2025 20:00 Inactive
@helios-aet helios-aet bot temporarily deployed to artemis-staging-localci.artemis.cit.tum.de April 1, 2025 20:14 Inactive
Copy link
Member

@bensofficial bensofficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Great that we can integrate deployments with Ansible 🚀
Just a few small questions/suggestions for improvement.

@github-project-automation github-project-automation bot moved this from Work In Progress to Ready For Review in Artemis Development Apr 2, 2025
coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 2, 2025
@Hialus Hialus changed the title Development: Deploy Artemis via Ansible (WIP) Development: Adapt staging deployment to use Ansible Apr 2, 2025
@Hialus Hialus added this to the 8.0.rc0 milestone Apr 2, 2025
@Hialus Hialus dismissed stale reviews from bensofficial and coderabbitai[bot] via a33db3d April 2, 2025 12:01
@Hialus Hialus requested review from bensofficial and Mtze April 2, 2025 12:02
coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 2, 2025
Copy link
Member

@Mtze Mtze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

@Hialus Hialus requested a review from Mtze April 2, 2025 13:36
Copy link
Member

@bensofficial bensofficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapprove

@ls1intum ls1intum deleted a comment from github-actions bot Apr 2, 2025
@ls1intum ls1intum deleted a comment from github-actions bot Apr 2, 2025
@ls1intum ls1intum deleted a comment from github-actions bot Apr 2, 2025
@ls1intum ls1intum deleted a comment from github-actions bot Apr 2, 2025
@ls1intum ls1intum deleted a comment from github-actions bot Apr 2, 2025
@ls1intum ls1intum deleted a comment from github-actions bot Apr 2, 2025
@ls1intum ls1intum deleted a comment from github-actions bot Apr 2, 2025
@Mtze Mtze merged commit fbc1b02 into develop Apr 2, 2025
8 of 11 checks passed
@Mtze Mtze deleted the feature/ci/ansible-deployments branch April 2, 2025 17:46
@github-project-automation github-project-automation bot moved this from Ready For Review to Merged in Artemis Development Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants