fix(workshopper): fix docker dns collisions for proxy and database#11
Merged
Conversation
florivn
approved these changes
Jul 15, 2026
florivn
left a comment
Contributor
There was a problem hiding this comment.
Copilot:
✅ Infrastructure fixes are solid:
- Docker DNS collision fix is correctly applied across all three locations (nginx.conf routes, compose.prod.yaml, and documented in AUTH.md)
- The hardened POSTGRES_HOST change prevents future DNS issues
✅ Refactoring is safe & well-executed:
- Type exports are properly defined: EditTarget and DndActivityBlock exported from WorkshopGeneratedTimetable.tsx (lines 37, 47)
- All imports are correct and match the exports
- Zero behavioral changes—pure code organization
- The extracted components (SortableBlockRow, InlineEditText) have all their handlers wired correctly with proper prop drilling
✅ Centralized utilities work correctly:
- parseStepDuration() correctly extracts duration from step strings and is used in three places (lines 164, 196 in main component)
- getSessionStatus() consolidates redundant status logic cleanly
- Constants (phaseEmojis, phaseRowColors, etc.) are properly accessed in both new component files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Infrastructure & Deployment Fixes
-Fixed NGINX Docker DNS Collision
-Hardened Database Connection
-Documentation Updates (AUTH.md)
Frontend Code Refactoring
-Extracted Shared Utilities (lib/utils.ts & lib/constants.ts)
-Component Modularization:
-Extracted InlineEditText into a dedicated, reusable component to clean up the timetable views.
-Extracted SortableBlockRow to isolate the complex drag-and-drop row rendering logic.
-Cleaned Up Dashboards