feat(learninggoalhub): learning-goals/skills concept switch + skill view improvements#15
Merged
Merged
Conversation
…skills concepts Replace the view pills with a primary segmented switch between the two concepts (extracted learning goals per session vs. the synthesised skill forest), with an explainer line and a dialog describing how they relate. Skills keep a quiet Map/Table sub-toggle; the drafted horizontal dendrogram view was dropped after design exploration.
…kill siblings The focused view previously had no way back to the all-skills overview and hid a focused sub-skill's siblings behind a picker overlay. The top pill now returns to the overview grid, and the sibling row stays visible (dimmed, directly clickable) with the knowledge branch anchored under the focused sub-skill; both shelf overlays are gone. Escape walks the drill path up one level. Boxes gain the table view's role-tinted left rail and a muted knowledge background.
…l detail Add a quiet last Session column to the tree-grid (sortable, funnel filter, em dash for synthesised skills) and a Session card to the goal detail modal, so a node's origin stays visible after the per-session learning-goals list stops being the primary view.
yinggez
approved these changes
Jul 16, 2026
yinggez
left a comment
yinggez
left a comment
Contributor
There was a problem hiding this comment.
Copilot:
✅
-Clear IA restructure
-UX polish
-Solid state management
-Correct interactivity
-CSS consistency
-CI green
-Deeply nested ternaries in Box title logic (CompetencyGraph.tsx, lines 375–381)
-Duplicated opacity dimming logic (CompetencyGraph.tsx, lines 519–521, 531–533)
-Inline geometric calculations (CompetencyGraph.tsx, lines 232–257)
-Session column filtering may scale poorly (CompetencyTree.tsx, lines 201, 683)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
How it was tested
npm run typecheck,npm run lintandnpm run buildpass inapps/learninggoalhub/client.