SP-2630: Improve plot-navigator navigation UI #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmullaney
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
Looks good to me. These are all really nice features/fixes.
My only query is that the ticket says "Ability to navigate to a specific page in the list of plots, or a specific visit/tract", but I only seem to be able to do the former. Am I able to put in a tract or visit ID number somewhere and jump straight to that?
|
For this ticket I punted on the "enter tract/visit" goal since it needs some UI design, and I didn't offhand have a good idea for what that should look like. Will keep that on the todo list for future tickets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few UI improvements:
This also includes an auto-reformatting of a lot of the javascript code, in bulk in a single commit.