Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Detect Language #20

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Migrate Detect Language #20

merged 1 commit into from
Sep 18, 2024

Conversation

abpai94
Copy link
Contributor

@abpai94 abpai94 commented Jul 17, 2024

#19

@coudot coudot added this to the 0.3.0 milestone Jul 17, 2024
@coudot coudot linked an issue Jul 17, 2024 that may be closed by this pull request
Migrate Detect Language #19
Closed
@coudot coudot added the enhancement New feature or request label Jul 17, 2024
@coudot coudot self-requested a review July 17, 2024 07:04
@davidcoutadeur davidcoutadeur self-requested a review July 18, 2024 08:36
davidcoutadeur
davidcoutadeur requested changes Jul 18, 2024
View reviewed changes
Copy link

@davidcoutadeur davidcoutadeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Globally, it seems good to me! Thanks for the unit tests.

Some minor changes requested. (see the review)

Also: please squash your commits into one

phpunit.xml Outdated Show resolved Hide resolved
tests/Ltb/LanguageTest.php Outdated Show resolved Hide resolved
@abpai94
Copy link
Contributor Author

abpai94 commented Sep 18, 2024 •
edited
Loading

@davidcoutadeur this is ready to be merged after implementing tests and your review comments.
It will enable ltb-project/self-service-password#943 move forward to complete SSP v1.7.0

@abpai94 abpai94 mentioned this pull request Sep 18, 2024
Open
@abpai94 abpai94 force-pushed the 19-migrate-detect-language branch 2 times, most recently from a2ec65f to 49fead9 Compare September 18, 2024 09:56
@abpai94
Copy link
Contributor Author

abpai94 commented Sep 18, 2024

@davidcoutadeur implemented changes, ready to be merged!

@davidcoutadeur davidcoutadeur merged commit 2469ffb into ltb-project:main Sep 18, 2024
1 check passed
@davidcoutadeur davidcoutadeur deleted the 19-migrate-detect-language branch September 18, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcoutadeur davidcoutadeur davidcoutadeur requested changes

@coudot coudot Awaiting requested review from coudot

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Migrate Detect Language
3 participants
@abpai94 @davidcoutadeur @coudot