Feat http notifications #552
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements HTTP notifications, as discussed here: #280
Generic enough to integrate with Slack or Rocket.Chat, and probably any POST/GET/PUT based webservice.
Maybe as a TODO, look into some alternative attribute in LDAP, should logins differ.
Having Rocket.Chat and SelfServicePassword configured against the same LDAP: works perfectly.
Regarding Slack, although Business & Enterprise may configure their workspace authenticating users SAML: Free Plan users may need some additional code, routing notifications to proper user - if your Slack username doesn't match the
$ldap_login_attributestored in LDAP.