141 rpm spec file cleanup #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcoutadeur
force-pushed
the
141-rpm-spec-file-cleanup
branch
from
e86a72c
to
d9b5875
Compare
Closed
Drop deprecated Group and BuildRoot tags Don't clean buildroot at start of %%install and drop %%clean section Re-order preamble and drop useless variables Use %%global instead of %%define Split long line in %%description Split long lines / simplify Don't change dirs ownership in %%post Drop default %%defattr Convert License tag to SPDX and distribute LICENSE file Distribute AUTHORS and README.md Move conf file to %%_sysconfdir Use macros instead of straigh paths Drop comments duplicating sections name Add blank lines between changelog entries for legibility Fix changelog entries format Use full URL for Source0 Add provides for bundled stuff Run checks (Fedora only) Specify all deps and provide a custom autoloader Specify min php version Install a minimal local config Re-order directories creation Preserve timestamps Update URL tag
davidcoutadeur
force-pushed
the
141-rpm-spec-file-cleanup
branch
5 times, most recently
from
b2bf612
to
5083980
Compare
* remove all files in htdocs/vendor/ except i18n in datatables, because they'll be managed by composer * add .gitignore in htdocs/vendor/ to ensure no files would be tracked there except for htdocs/vendor/datatables/i18n * improve composer.json file to clean the downloaded dependencies and keep only the required files in htdocs/vendor * clean specfile: add bundled dependencies, remove custom autoload and local config file, manage the config file migration to /etc/service-desk, clean hidden files in bundled php libs, fix license filename, add missing htdocs/js directory, remove httpd and add php-fpm dependency
davidcoutadeur
force-pushed
the
141-rpm-spec-file-cleanup
branch
from
5083980
to
9830794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #141