feat: Add widening effect support for stereo output #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new CLI option `--stereo-phase-shift` to apply a phase shift to stereo audio, allowing values between -1.0 and 1.0. - Implemented `apply_phase_shift` function using an all-pass filter to modify the phase response of audio without significant amplitude alteration. - Updated `TTSOpts` to include a `stereo_phase_shift` parameter. - Adjusted audio generation logic to apply the phase shift for stereo outputs, ensuring compatibility with mono and stereo modes. - Added warnings for invalid phase shift values or conflicting mono mode usage, providing clipping behavior when necessary. This update enables a stereo widening effect through phase-shifted audio in the right channel when in stereo mode.
Updated the conditional check for `stereo_phase_shift` to account for both positive and negative values by replacing `> 0.0` with `!= 0.0`. This ensures phase shifts are correctly applied regardless of direction.
|
Hi, would this make output audio sounds weired on PCs? they maybe not support spatial stereo effect actually like iOS devices does. |
|
I am no audio expert, but the widening effect made the headphone listening experience better imho.. |
|
looks there is some conflict as new features comes in, would like resolve it before merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add stereo phase shift support for audio output
--stereo-phase-shiftto apply a phase shift to stereo audio, allowing values between -1.0 and 1.0.apply_phase_shiftfunction using an all-pass filter to modify the phase response of audio without significant amplitude alteration.TTSOptsto include astereo_phase_shiftparameter.This update enables a stereo widening effect through phase-shifted audio in the right channel when in stereo mode.