Updates to TextReponse#print #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing to the response then just log the error. Generally there's not much we can do at this point. Fixes #1608
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #1608
Description
When you make a
HEADcall to aGETroute, no body is to be returned. We have been writing the body. There was a spec to test that, but it was incorrectly checking therequest.bodyand not theresponse.body.I've also added a catch for when we do write to the response, but the response has already been closed. This may be an issue related to Crystal directly crystal-lang/crystal#9065 but for now, we can just rescue that exception, and log out an error. Chances are, the client left before we were able to respond, so the exception does us no good anyway.
Checklist
crystal tool format spec src./script/setup./script/test