Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error #1910

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

akadusei
Copy link
Contributor

@akadusei akadusei commented Aug 12, 2024

Purpose

Fixes: #1906

Fix compile error arising from crystal-loot/exception_page

Description

Exception page shard introduced a breaking change on their master branch, leading to compile error in Lucky:

In src/lucky/error_action.cr:83:34

 83 | body: Lucky::ExceptionPage.for_runtime_exception(context, error).to_s,
                                 ^--------------------
Error: Error: undefined method 'for_runtime_exception' for Lucky::ExceptionPage.class

See crystal-loot/exception_page#49.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

```
In src/lucky/error_action.cr:83:34

 83 | body: Lucky::ExceptionPage.for_runtime_exception(context, error).to_s,
                                 ^--------------------
Error: Error: undefined method 'for_runtime_exception' for Lucky::ExceptionPage.class
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Exception Page
1 participant