-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the new architecture #732
base: master
Are you sure you want to change the base?
Conversation
Is there any progress? |
@luancurti Are there any plans to review this PR? If so, I can merge the main branch and update the app to 0.73. |
I don't think this project is actively maintained anymore since last release was more than a year ago, maybe it makes sense to publish/maintain a fork supporting RN >=0.72 ? |
@luancurti would it be possible to have it merged and released? I updated the PR to the newest |
@luancurti Could we get this PR merged in? |
PR adding New Architecture support to the library 🎉
We at Software Mansion have been working on improving support for the new architecture for quite a while now. If you need help with anything related to New Architecture, like:
or you just want to ask any questions, hit us up on [email protected]
This PR:
FabricExample
app with the new arch enabled by defaultgetConstants()
must be returning object literal on iOS and type safety is enforced on Android), I've moved constants exported by the native module intoconstants
object, i.e. instead of returning{ constant1: 'value1', constant2: 'value2' }
the native side now returns{ constants: { constant1: 'value1', constant2: 'value2' } }
The changes in this PR apply to iOS and Android codebase, I've tried to make sure that Windows is unaffected but I cannot test it.