Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the new architecture #732

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

j-piasecki
Copy link

@j-piasecki j-piasecki commented Feb 20, 2023

PR adding New Architecture support to the library 🎉

We at Software Mansion have been working on improving support for the new architecture for quite a while now. If you need help with anything related to New Architecture, like:

or you just want to ask any questions, hit us up on [email protected]


This PR:

  • adds a new FabricExample app with the new arch enabled by default
  • converts the library to a TurboModule
  • due to some codegen quirks (getConstants() must be returning object literal on iOS and type safety is enforced on Android), I've moved constants exported by the native module into constants object, i.e. instead of returning { constant1: 'value1', constant2: 'value2' } the native side now returns { constants: { constant1: 'value1', constant2: 'value2' } }

The changes in this PR apply to iOS and Android codebase, I've tried to make sure that Windows is unaffected but I cannot test it.

@yidafu
Copy link

yidafu commented Oct 23, 2023

Is there any progress?

@j-piasecki
Copy link
Author

@luancurti Are there any plans to review this PR? If so, I can merge the main branch and update the app to 0.73.

@denissb
Copy link

denissb commented Apr 22, 2024

I don't think this project is actively maintained anymore since last release was more than a year ago, maybe it makes sense to publish/maintain a fork supporting RN >=0.72 ?

@WoLewicki
Copy link

@luancurti would it be possible to have it merged and released? I updated the PR to the newest master so it should be ready 🚀

@airowe
Copy link

airowe commented Oct 14, 2024

@luancurti Could we get this PR merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants