Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows bump WindowsTargetPlatformMinVersion #752

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TatianaKapos
Copy link

In RNW .72, we bump WinUI from 2.7 to 2.8 which targets a higher TargetPlatformMinVersion. This PR bumps the WindowsTargetPlatformMinVersion to the correct version for RNW .72

@TatianaKapos
Copy link
Author

@luancurti would you mind looking at this PR when you have the chance? :) It will block RNW apps from using .72

@VMBindraban
Copy link

https://microsoft.github.io/react-native-windows/docs/win10-compat

10.0.17763.0 was introduced in the October 2018 update.

Can you also set the WindowsTargetPlatformVersion to 10.0?

As of Visual Studio 2019 (v16 or v142) and Visual Studio 2022(v17 or v143) you can simply specify "10.0". This allows a lot more flexibility to the developer or build machine as there is a growing number of different windows 10 SDK out there now.

@VMBindraban
Copy link

@luancurti Do you have an ETA when this can be checked/merged? It is blocking React 0.72+ users from using this library on windows.

@TatianaKapos
Copy link
Author

@VMBindraban updated! And if you're trying to use this community module without this PR, we were able to make it work by patching the package using postinstall! See this PR: microsoft/react-native-gallery#343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants