Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): add support namespace and rn 0.73 #779

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ngocle2497
Copy link

add support namespace and rn 0.73

@DriesVS
Copy link

DriesVS commented Jan 9, 2024

@masonle2x2 🙌🏻

@luancurti @pedro this fixes a breaking issue with react native 0.73.x. Can you merge & publish a new version, please? Thanks

android {
if(supportsNamespace()){
namespace = "com.reactnativecommunity.webview"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be com.lugg.RNCConfig

@@ -0,0 +1,3 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.lugg.RNCConfig">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package should be removed here

@samueljim
Copy link

bump on this :)

1 similar comment
@Himatheja
Copy link

bump on this :)

@chuongvu137
Copy link

bump on this 👍

@samueljim
Copy link

bump on this 👍

I moved my entire stack over this REUC which has been super amazing. I would still be using this framework if they were still maintaining it
https://github.com/maxkomarychev/react-native-ultimate-config/blob/master/docs/quickstart.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants