-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): add support namespace and rn 0.73 #779
base: master
Are you sure you want to change the base?
Conversation
@masonle2x2 🙌🏻 @luancurti @pedro this fixes a breaking issue with react native 0.73.x. Can you merge & publish a new version, please? Thanks |
android { | ||
if(supportsNamespace()){ | ||
namespace = "com.reactnativecommunity.webview" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be com.lugg.RNCConfig
@@ -0,0 +1,3 @@ | |||
<manifest xmlns:android="http://schemas.android.com/apk/res/android" | |||
package="com.lugg.RNCConfig"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package should be removed here
bump on this :) |
1 similar comment
bump on this :) |
bump on this 👍 |
I moved my entire stack over this REUC which has been super amazing. I would still be using this framework if they were still maintaining it |
add support namespace and rn 0.73