✨ Use new Pay-Wall Dialog in layout

[lukevella]

Continuing from #1357

Summary by CodeRabbit

• New Features

  • Introduced a PayWallDialog component to enhance user interaction and manage access to premium features.
  • Replaced sidebar billing link with a button that triggers the paywall dialog for free users.

• Improvements

  • Streamlined the DuplicateDialog component by removing unnecessary wrappers, simplifying the duplication process.

• Refactor

  • Updated the PayWallDialog to improve state management and flexibility in rendering dialog content.

• Updates

  • Adjusted the ManagePoll component to utilize the newly structured PayWallDialog.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Sep 20, 2024 10:10pm
landing	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 20, 2024 10:10pm

[coderabbitai]

Walkthrough

The changes introduce a new PayWallDialog component that enhances the layout and user interaction within the application. The original layout structure has been modified to incorporate this dialog, which now wraps the entire content of the layout. Additionally, the sidebar has been updated to trigger the paywall dialog instead of navigating to a billing page. The DuplicateDialog component has been simplified by removing the PayWallDialogContent, and the PayWallDialog has been refactored to improve state management and flexibility in rendering content.

Changes

Files	Change Summary
apps/web/src/app/[locale]/(admin)/layout.tsx, apps/web/src/app/[locale]/(admin)/sidebar.tsx	Introduced PayWallDialog component to wrap the layout and modified the sidebar to trigger the paywall dialog instead of linking to billing settings.
apps/web/src/app/[locale]/poll/[urlId]/duplicate-dialog.tsx	Removed PayWallDialogContent wrapper from DuplicateDialog, simplifying the structure while retaining the core functionality.
apps/web/src/components/pay-wall-dialog.tsx	Renamed PayWallDialogContent to PayWallDialog, updated state management, and enhanced flexibility by accepting children props.
apps/web/src/components/poll/manage-poll.tsx	Updated import and usage of PayWallDialog in the ManagePoll component, reflecting the recent changes to the paywall dialog structure.

Possibly related PRs

• ✨ Use dialogs to finalize and duplicate polls #1099: This PR involves the DuplicateDialog component, which previously utilized the PayWallDialogContent. The changes in the main PR introduce a new PayWallDialog component that alters the dialog structure, making it relevant to the modifications in how dialogs are handled in the duplication process.

• ✨ Better Pay-Wall Experience #1357: This PR focuses on enhancing the PayWallDialogContent, which is directly related to the changes made in the main PR that introduces the PayWallDialog component. Both PRs deal with improving the user experience around the paywall feature.

🐇 In the meadow, hops a little hare,
With a dialog of paywalls, oh what flair!
No more links to billing, just a friendly chat,
Upgrades await, imagine that!
With each click and hop, the features grow,
A joyful journey, come join the show! 🌼

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 92f294f and db78ad0.

Files selected for processing (5)

• apps/web/src/app/[locale]/(admin)/layout.tsx (1 hunks)
• apps/web/src/app/[locale]/(admin)/sidebar.tsx (3 hunks)
• apps/web/src/app/[locale]/poll/[urlId]/duplicate-dialog.tsx (1 hunks)
• apps/web/src/components/pay-wall-dialog.tsx (2 hunks)
• apps/web/src/components/poll/manage-poll.tsx (2 hunks)

Additional comments not posted (6)

apps/web/src/app/[locale]/(admin)/layout.tsx (1)

16-36: LGTM! The PayWallDialog component has been integrated into the layout correctly.

The changes introduce the PayWallDialog component, which wraps the entire layout structure, including the sidebar, main content area, and mobile navigation. The overall structure of the layout remains the same, with the PayWallDialog component acting as a new top-level container.

Could you please provide more information about the purpose and behavior of the PayWallDialog component? It would be helpful to understand how it interacts with the user and what specific functionality it introduces related to the paywall or subscription system.

apps/web/src/app/[locale]/poll/[urlId]/duplicate-dialog.tsx (1)

32-77: LGTM!

The removal of the PayWallDialogContent component simplifies the DuplicateDialog structure while preserving the core functionality. The changes align with the provided summary and do not introduce any apparent issues.

apps/web/src/app/[locale]/(admin)/sidebar.tsx (1)

107-125: LGTM!

The changes enhance the user experience for free users by replacing the link to the billing settings with a visually appealing button that triggers a paywall dialog. The custom button layout provides more context about the upgrade, and wrapping the change inside IfFreeUser ensures that the upgrade prompt is only shown to free users.

The code changes are well-structured and do not introduce any apparent issues or inconsistencies.

apps/web/src/components/pay-wall-dialog.tsx (1)

32-38: LGTM!

The changes made to the PayWallDialog function improve its structure and flexibility:

• Using the useDialog hook for dialog state management is a good practice.
• Accepting children as a prop enhances the flexibility of the dialog's content.
• Forwarding additional props to the Dialog component using forwardedProps is a good pattern for extensibility.
• Using React.useState for state management is a standard React practice.

Overall, the changes are well-structured and follow best practices.

apps/web/src/components/poll/manage-poll.tsx (2)

31-31: LGTM!

The import statement change looks good. Using the PayWallDialog component from a more generic location makes it reusable across the application.

---

277-277: Looks good!

The usage of the PayWallDialog component is consistent with the updated import statement. The props being passed remain the same, ensuring the functionality is preserved.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.