This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Improved the installer by code cleanup and some fancy stuff - #58
Open
FxRie wants to merge 5 commits into
Open
Conversation
FxRie
commented
Jun 26, 2020
FxRie
commented
- Moved the versioning to the assembly info.
- Started to refactor the installer for better readability and async behavior.
- Still got stuff todo like the registration for the events used by console and the forms app
Author
|
Some stuff for you to first look around. Got some questions to be answered. Started to refactor and use async stuff. Console output in winform app still should be improved. |
Owner
|
Looks good from first glance. Tried to run a quick test and ran into some unintended issues.
I only did a quick test run so maybe I had some specific problems on my end. Do these issues occur on your end? I'll take a look into the problems in more depth once I have time. |
FxRie
force-pushed
the
feature/UpdatedTheInstallerByCodeCleanup
branch
from
June 29, 2020 23:05
d22eb30 to
9551e53
Compare
- Moved the versioning to the assembly info. - Started to refactor the installer for better readability and async behavior. - Still got stuff todo like the registration for the events used by console and the forms app Improved InstallerSettings and added ENUM for them. Improved performance and code refactorings -Used async await improved the installer settings more. - Improved workflow and added async read operation. Used VS Code cleanup after setting it up Refactored some more - Added specific handlers for cmd or view mode if the installer. Removed same code for event attachments. Improved the logging by time prefix Corrected some names and added better workflow for some stuff. Improved by global exception handle
FxRie
force-pushed
the
feature/UpdatedTheInstallerByCodeCleanup
branch
from
June 29, 2020 23:49
c3e6800 to
ea68044
Compare
updated master according to forked master
Ready for 3.0.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.