Skip to content

refactor(core): SCSS code cleanup and simplifications #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

refactor(core): SCSS code cleanup and simplifications #1329

wants to merge 3 commits into from

Conversation

@gcornut
Copy link
Member

@gcornut gcornut commented Sep 11, 2025 •
edited
Loading

  • Inline .#{$lumx-base-prefix} into .lumx
  • Inline lumx-base-const calls
  • Other minor simplifications (button size styles, tab links style)

Test scenario

Produced CSS should not change at all (except for the tab link style simplification)

@gcornut gcornut force-pushed the refactor_core_SCSS_code_cleanup_and_simplifications branch from 626a27f to 10aa350 Compare September 11, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lumautomation lumautomation Awaiting requested review from lumautomation lumautomation will be requested when the pull request is marked ready for review lumautomation is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gcornut