refactor(components): uniformize handling of link and button #1348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcornut
force-pushed
the
refactor_components_uniformize_handling_of_link_and_button
branch
9 times, most recently
from
60ab4a0 to
c8c0eae
Compare
gcornut
force-pushed
the
refactor_components_uniformize_handling_of_link_and_button
branch
from
92870f0 to
016ac56
Compare
gcornut
force-pushed
the
refactor_components_uniformize_handling_of_link_and_button
branch
from
016ac56 to
a159f59
Compare
juanigalan91
approved these changes
Nov 20, 2025
Member
Author
|
Test OK ✅ |
gcornut
deleted the
refactor_components_uniformize_handling_of_link_and_button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General summary
Uniformize handling of HTML button or link (
<a>) with a shared RawClickable component.Make disabled links render as
<a aria-disabledinstead of the fallback on disabled button.StoryBook: https://c8c0eae7--5fbfb1d508c0520021560f10.chromatic.com/ (Chromatic build)⚠️ Outdated commit