Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Generalize attribute data field state handling in Filament #2105

Draft
wants to merge 2 commits into
base: 1.x
Choose a base branch
from
Draft

Feat: Generalize attribute data field state handling in Filament #2105

wants to merge 2 commits into from

Conversation

repl6669
Copy link
Contributor

@repl6669 repl6669 commented Feb 14, 2025 •
edited
Loading

Description

This PR aims to generalize how attribute data fields are handled in Filament and fix #2091 and #2071.

  1. Component state for all fields is set to field value by using the ->getValue() method.
  2. Instance of the field with its value set is returned after dehydration

Todo

  • Test that fields are rendered correctly on ProductEditPage
  • Test that the form is saved correctly for all Lunar fields as well as custom, user defined fields

@vercel Vercel
Copy link

vercel bot commented Feb 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 10:23am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Attribute File Field Type Fails to Save Due to Strict Type Comparison in AttributeData
1 participant
@repl6669