Fix: Applying multiple discounts results in incorrect discountTotal #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…Discount and discountBreakdown contain both discounts, but the discountTotal of the Cart and CartLine only contained the value of the last Discount. This inconsistency resulted in values not correctly adding up in the Admin Panel Order Detail and other places. This commit fixed both the discountTotal of the Cart and the CartLine to match the discountBreakdown, subTotalDiscounted & total
tvlokven
force-pushed
the
fix-discount-total-for-multiple-discounts
branch
from
382a72a to
75c39b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: When multiple Discounts apply to the same CartLine, the subTotalDiscount and discountBreakdown contain both discounts, but the discountTotal of the Cart and CartLine only contained the value of the last Discount.
This inconsistency resulted in values not correctly adding up in the Admin Panel Order Detail and other places.
This commit fixed both the discountTotal of the Cart and the CartLine to match the Cart's discountBreakdown, subTotalDiscounted & total.