perf(draw): optimize lv_draw_label() with text_length for text_local #7673
+80
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasf
force-pushed
the
perf/draw-label-slice
branch
3 times, most recently
from
351cecd to
b9da0c9
Compare
uLipe
requested changes
Jan 29, 2025
liamHowatt
previously approved these changes
Jan 31, 2025
Introduce lv_strnlen() and lv_strndup(), mirroring the standard C library. When using lv_draw_label() with text_length and text_local to draw a slice of a larger string, copy only the required part.
niklasf
force-pushed
the
perf/draw-label-slice
branch
from
b9da0c9 to
26f7f55
Compare
liamHowatt
approved these changes
Feb 4, 2025
|
@uLipe I think we should try to make any functions that mimic C library functions as compliant as possible. i.e., the caller handles failures instead of crashing in str(n)dup, and invalid input is UB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
lv_strnlen()andlv_strndup(), mirroring the standard C library.When using
lv_draw_label()withtext_lengthandtext_localto draw a slice of a larger string, copy only the required part.Depending on the size of the larger string, this can be anywhere from insignificant to a major improvement.
I think the additional standard library functions are useful, but it would also be possible to manually malloc and copy diretcly in the draw function.