fix(nema): Broken build after draw unit refactoring, draw_label changes #7759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uLipe
previously approved these changes
Feb 12, 2025
|
@liamHowatt @uLipe @kisvegabor Also fixes #7723 |
uLipe
requested changes
Feb 13, 2025
kisvegabor
reviewed
Feb 13, 2025
|
Also found ticket for e-bike glitch, was #7439 |
kisvegabor
approved these changes
Feb 14, 2025
|
Thank you! @uLipe when you will have some spare time, please check Dave2D and update it if needed. |
Will you send a PR for this? |
|
@kisvegabor It is fixed in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7691
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle v3.4.12needs to installed by runningcd scripts; ./install_astyle.sh) and follow the Code Conventions.