Add convert_to_circular function to imaging utils #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option to convert VisibilityDataSets that are in the stokes polarization basis into the circular polarization basis.
Add test suite for new function.
add convert_to_circular to __all__
jaycedowell
reviewed
Mar 6, 2025
lsl/imaging/utils.py
Outdated
| if 'Q' in data_set.pols and 'U' in data_set.pols: | ||
| pairs += 1 | ||
| if pairs == 0: | ||
| raise RuntimeError("Too few Stokes parameters to form any linear polarization products") |
jaycedowell
reviewed
Mar 6, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
- Coverage 84.03% 84.02% -0.01%
==========================================
Files 83 83
Lines 24290 24337 +47
==========================================
+ Hits 20411 20449 +38
- Misses 3879 3888 +9
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality and testing to convert to circular polarization in the imaging utils.