-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add A cli version #18
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,325 @@ | |||
#!/usr/bin/env python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I'd rather refactor the main.py one to accept cli args
I will say, I would rather keep the implementations cleaner for learning purposes. This is one of the easiest to grasp and understand repo on how to fine tune a project, and is a great learning example. If anything, it should be split into 3 files. Obviously as the author you can choose what you want, but for those coming to your repo as one of the few easy examples of fine tuning, it might be better to keep things cleanly laid out instead of lumped into 1 file. |
If it's possible to add a separate file that can be invoked to do CLI training, i would love that. I am currently attempting to run training via CLI; I will have a look at this branch. |
You did an amazing job.
But most people wants a cli version to quickly get started and play around.
Here it is.
Cheers.