Added dockerfile and updated README#135
Added dockerfile and updated README#135MartinTerp wants to merge 4 commits intolxgr-linux:masterfrom MartinTerp:docker
Conversation
|
Its also hosed on docker hub: https://hub.docker.com/r/terpz/pokete |
MaFeLP
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution!
Other publishing methods have been standing on our To-Do List for at least a couple of months!
Please just add a .dockerignore file, containing the directories .git and __pycache__, as these directories are getting the image size WAAAY up.
After that, I think we are ready to merge!
|
Thanks for the docker hub idea. If you want, you could also contribute the GitHub Action to push to ghcr.io and docker hub. If not, I would look into it in the next coming days/weeks. |
Co-authored-by: MaFeLP <60669873+MaFeLP@users.noreply.github.com>
|
Seems fair, regardin the version and the debian image. Eventhough im against the symlink in the dockerfile (just think it looks ugly ;) ) im willing to make an exception ^^ |
|
|
||
| WORKDIR /usr/src/app | ||
|
|
||
| RUN pip install --no-cache-dir scrap_engine && \ |
There was a problem hiding this comment.
| RUN pip install --no-cache-dir scrap_engine && \ | |
| RUN pip install --no-cache-dir scrap_engine playsound pygobject && \ |
I would suggest adding those two dependencies, which have been added with the Sound PR.
There was a problem hiding this comment.
This wont build, because it needs libs and compilers in the image.
I will see what i can do, hopefully i can do some magic with multistage dockerbuild
There was a problem hiding this comment.
you can build your container like so and save about 275MB~ over a non-multistage image:
FROM alpine:3.15 AS compile-image
RUN apk add \
python3-dev \
py3-pip \
py3-gst \
gobject-introspection-dev \
cairo-dev \
build-base
RUN python3 -m pip install --user scrap_engine playsound pygobject
From alpine:3.15
RUN apk add --no-cache \
python3-dev \
py3-gst
COPY --from=compile-image /root/.local /root/.local
ENV PATH="/root/.local/bin:$PATH"
RUN mkdir -p /root/.cache/pokete && \
ln -s /root/.cache/pokete /data
COPY . .
VOLUME ["/data"]
CMD [ "python", "./pokete.py" ]
Added the dockerfile from pull request #135, as there seems to be no more work being done on it. Currently sound does not work with docker. Co-authored-by: MartinTerp <terp@boot.dk> Co-authored-by: Victim <94010769+anothervictimofsurvivalinstinct@users.noreply.github.com>
No description provided.