pull request from myeong-ji univercity computer engineering opensource-software class project#255
Open
taew0o wants to merge 1 commit intolxgr-linux:masterfrom
Open
pull request from myeong-ji univercity computer engineering opensource-software class project#255taew0o wants to merge 1 commit intolxgr-linux:masterfrom
taew0o wants to merge 1 commit intolxgr-linux:masterfrom
Conversation
Author
|
In addtion, we added some pokemon and attacks and a achievement. |
TheKingOfLight
pushed a commit
to TheKingOfLight/pokete
that referenced
this pull request
Jan 31, 2024
Merged most of ta-mj requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi lxgr-linux,
I am taewoo Park from Myeong-ji Univercity Computer Engineering.
My project group in opensource-software class had to analyze and improve one opensource software project.
So We chose your pokete project and proceed project activity.
And we find some improvement point.
The modifications about them are as follows.
char change to name's first letter.
So, we modified the code to start the conversation when you press the 'Accept' key when you go near the NPC.
Battle and some attack animations are too long to make users bore the user. So just like conversation with NPC,
we modified the code to skip the animation when you press the 'Accept' key.
And more, we modified the probablility of pokemon appearance, remove the effect, attack when poke is in effect.
And we increased poke's hp when they level up, and we improved all poke's damage.
We want to hear your feedback and want to be the contributor of your project.
Thank you.